Conversation
Builds the libvalkey Python bindings (a hiredis-style C extension over the vendored libvalkey C client, checked out as a submodule) for riscv64, mirroring hiredis's own build-from-checkout shape since libvalkey-py has the same setup.py + vendored-submodule layout and no pyproject.toml. Carries a licensing patch, following the precedent set for hiredis: setuptools' default LICEN[CS]E* glob only picks up files at the project root, so the vendored libvalkey C library's BSD-3-Clause COPYING notice (required by its redistribution clause) is missing from the wheel unless copied there as LICENSE.libvalkey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libvalkey4.1.0Compiles the libvalkey Python bindings, a C extension linking the vendored libvalkey C client library (checked out as a submodule) for the Valkey/Redis protocol. Upstream publishes no riscv64 wheel.
Mirrors upstream's
pypi-publish.yaml.Differs from upstream
Testing
License: package is MIT; the wheel also bundles the vendored libvalkey C library (BSD-3-Clause), whose
COPYINGnotice setuptools does not glob intodist-infoby default, so a patch adds it asLICENSE.libvalkey.Patches
0001-add-the-vendored-libvalkey-licence-next-to-the-pack.patch- To upstream [not yet submitted; the same gap exists in every libvalkey wheel on PyPI]. Wheel ships without the vendored BSD-3-Clause notice without it; reproduces off riscv64 too.Built on cp312; TBD passed, TBD skipped.